Update rector.php #111
Merged
Update rector.php #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
force-pushed
the
update-rector
branch
from
eeb9c5b
to
c607bba
Compare
|
Consider moving Rector from |
|
@MGatner What is it? Can you give me a reference? Ah, this repo is devkit, and if you install this as dev dependency, it should also install rector? |
|
Correct! So our other libraries that depend on DevKit won't need to add Rector to their dev requirements. I think we want Rector everywhere so this would be a safe, central place to control the version. |
1 task
|
That makes sense! |
MGatner
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update from codeigniter4/shield#811